Dale Farnsworth wrote:

In article [ref] Nicolas wrote:
  

quoted

This patch add MPC52xx Interrupt controller for ARCH=powerpc.

It includes the main code in arch/powerpc/sysdev/ ad well as an header
file in include/asm-powerpc.

Signed-off-by: Nicolas DET <redacted>
    

NAK.

Two requests:
  1.  Please include patches inline so that they may be easily reviewed.
  2.  Please do not remove copyright lines from files you modify.
  

Indeed.



Dale Farnsworth wrote:

Wow, the source code size sure ballooned in this revision.

I'd like to see us go the other direction, with something like the
following (untested code).
  

Well that's kind of a contradiction with what benh asked (separate IC
chips).

static inline void io_be_setbit(u32 __iomem *addr, int bitno)
{
	out_be32(addr, in_be32(addr) | 1 << bitno);
}

static inline void io_be_clrbit(u32 __iomem *addr, int bitno)
{
	out_be32(addr, in_be32(addr) & ~(1 << bitno));
}
  

Those could still be used to cleanup a little the code.


    Sylvain