Re: [PATCH 1/6] bootwrapper: arch/powerpc/boot code reorg

On Mon, Aug 07, 2006 at 04:48:43PM +1000, Paul Mackerras wrote:

Mark A. Greer writes:

quoted

I realize that I didn't really answer your question.  Its at least
possible that the console driver could not be known at link time.

An example I used in another email is a platform that has 4 serial
ports, 2-16550 and 2-mpsc, say.  The /chosen/linux,stdout-path could
pick any of the four so you would need to compile in a low-level
serial driver for both and hook the correct one up at runtime.

Same could be said for a serial vs. video console.

OK, that's reasonable.  Still would be nice not to have to do the
double dereference though.

Yep, I'll get rid of the double dereference.

I think that the platform_ops and the
fw_ops could probably be combined.

Okay.

Also, an init method for the
platform/fw_ops would be useful

Hm, I don't understand what you mean here.  I already have
'platform_init()' called from start().  Is that not sufficient?

- it would let us remove the kludge
you have in the OF malloc implementation.

The OF malloc routine was a straight copy of what was already
in try_claim() in main.c.  As I look at try_claim() now, though,
I see that its changed.  I can get rid of that code inside the
"#if defined(PROG_START)".  Is that the kludge you were referring to?

The OF malloc is currently applying a minimum address constraint for
all platforms, where it used to apply it only for 64-bit platforms.
We need to fix that up somehow too.

Okay. 

Mark