Re: [PATCH 1/6] bootwrapper: arch/powerpc/boot code reorg

On Wednesday 02 August 2006 06:53, Paul Mackerras wrote:

quoted

+#ifdef __powerpc64__
+typedef unsigned long=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0u=

64;

quoted

+#else
+typedef unsigned long long=A0=A0=A0u64;
+#endif

=20
This is potentially confusing, because the __powerpc64__ relates to
the boot wrapper not the kernel, and we don't build a 64-bit boot
wrapper on any platform (not yet anyway). =A0Maybe this needs a comment.
=20

Moreover, even if we ever build this on __powerpc64__, the=20
typedef unsigned long long u64 would still do the right thing.
It only ever becomes a problem when mixing with u64 the c99 uint64_t,
which is defined the other way.

	Arnd <><