Re: [PATCH 1/6] bootwrapper: arch/powerpc/boot code reorg
From: Hollis Blanchard <hidden>
Date: 2006-08-07 00:21:58
On Wed, 2006-07-19 at 16:00 -0700, an unknown sender wrote:
quoted hunk ↗ jump to hunk
diff --git a/arch/powerpc/boot/types.h b/arch/powerpc/boot/types.h new file mode 100644 index 0000000..2a2fa2b --- /dev/null +++ b/arch/powerpc/boot/types.h@@ -0,0 +1,29 @@ +#ifndef _TYPES_H_ +#define _TYPES_H_ + +#define COMMAND_LINE_SIZE 512 +#define MAX_PATH_LEN 256 +#define ARRAY_SIZE(x) (sizeof(x) / sizeof((x)[0])) + +typedef unsigned char u8; +typedef unsigned short u16; +typedef unsigned int u32; +#ifdef __powerpc64__ +typedef unsigned long u64; +#else +typedef unsigned long long u64; +#endif
As long as we're adding new typedefs, could we please use the stdint.h ones (e.g. uint32_t)? For Xen, I need to do flat tree munging in userspace, so using real types would help with code reuse. -- Hollis Blanchard IBM Linux Technology Center