Re: [Alsa-devel] [RFC 3/8] snd-aoa: add soundbus

On Fri, 2006-06-02 at 15:53 +0200, Takashi Iwai wrote:

quoted

+		int l;
+		length += sprintf (buf, "%s\n", compat);
+		buf += length;

This seems wrong.  The above should be

Heh, no idea where I copied that from but I sure didn't write it myself.
Should be more careful next time I guess :)

quoted

+	if (strlen(sdev->modalias)) {
+		length = snprintf (buf, 34, "%s\n", sdev->modalias);

sizeof(sdev->modalias) + 2?  But still strange if modalias has no
nul-end.

Hm, how would I handle that if modalias has no nul?

johannes