Thread (28 messages) flat view 28 messages, 5 authors, 2002-06-15

Re: [PATCH] pci_alloc_consistent in an interrupt context

From: David Gibson <hidden>
Date: 2002-06-14 01:33:52

On Thu, Jun 13, 2002 at 06:25:11PM -0700, Eugene Surovegin wrote:
At 05:24 PM 6/13/2002, David Gibson wrote:
quoted
That's right.  But I think the patch below is a better fix for the
problem.  It makes consistent_alloc()/consistent_free() just do the
right thing for both cache coherent and cache non-coherent processors,
so we can get rid of the ifdef in pci_alloc_consistent() and
pci_free_consistent().
So, kmalloc will allocate non-cacheable memory?

I seriously doubt it (actually I've just tested it:).
No, but on cache coherent processors we don't need non-cacheable
memory.  That's the whole point.  Likewise with __get_free_pages()
which is what pci_alloc_consistent() uses on cache-coherent processors
now.

--
David Gibson			| For every complex problem there is a
david@gibson.dropbear.id.au	| solution which is simple, neat and
				| wrong.  -- H.L. Mencken
http://www.ozlabs.org/people/dgibson

** Sent via the linuxppc-embedded mail list. See http://lists.linuxppc.org/
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help