Re: [PATCH] pci_alloc_consistent in an interrupt context

On Fri, Jun 14, 2002 at 10:24:19AM +1000, David Gibson wrote:

On Thu, Jun 13, 2002 at 02:56:35PM -0700, Tom Rini wrote:

quoted

On Thu, Jun 13, 2002 at 05:47:32PM -0400, Dan Malek wrote:

quoted

Tom Rini wrote:

quoted

..... But I don't see (immediatly) why the change to
pci_alloc_consistent was needed as well.

It was a mistake on my part......when CONFIG_NOT_COHERENT_CACHE is used,
the consisten_alloc() returns the dma_handle, and we have to ensure we
don't do the virt_to_bus later to get it (because it will be wrong once
iopa() is discarded :-)

Ah..  So this part is a correct and necessary fix, separate from the
rest of the patch?

That's right.  But I think the patch below is a better fix for the
problem.  It makes consistent_alloc()/consistent_free() just do the
right thing for both cache coherent and cache non-coherent processors,
so we can get rid of the ifdef in pci_alloc_consistent() and
pci_free_consistent().

Er, the problem of setting dma_handle twice?

My only concern is that are things still consistent on non consistent
procs?

--
Tom Rini (TR1265)
http://gate.crashing.org/~trini/

** Sent via the linuxppc-embedded mail list. See http://lists.linuxppc.org/