Re: [PATCH 15/15] xfs: refactor per-AG inode tagging functions
From: Dave Chinner <david@fromorbit.com>
Date: 2021-06-03 01:16:35
From: Dave Chinner <david@fromorbit.com>
Date: 2021-06-03 01:16:35
On Wed, Jun 02, 2021 at 03:26:19PM -0700, Darrick J. Wong wrote:
From: Darrick J. Wong <djwong@kernel.org> In preparation for adding another incore inode tree tag, refactor the code that sets and clears tags from the per-AG inode tree and the tree of per-AG structures, and remove the open-coded versions used by the blockgc code. Note: For reclaim, we now rely on the radix tree tags instead of the reclaimable inode count more heavily than we used to. The conversion should be fine, but the logic isn't 100% identical. Signed-off-by: Darrick J. Wong <djwong@kernel.org> --- fs/xfs/xfs_icache.c | 158 +++++++++++++++++++++++++-------------------------- fs/xfs/xfs_icache.h | 2 - fs/xfs/xfs_super.c | 2 - fs/xfs/xfs_trace.h | 6 +- 4 files changed, 80 insertions(+), 88 deletions(-)
LGTM. Reviewed-by: Dave Chinner <redacted> -- Dave Chinner david@fromorbit.com