Re: [PATCH 05/15] xfs: pass the goal of the incore inode walk to xfs_inode_walk()
From: Dave Chinner <david@fromorbit.com>
Date: 2021-06-03 01:05:01
On Wed, Jun 02, 2021 at 03:25:24PM -0700, Darrick J. Wong wrote:
From: Darrick J. Wong <djwong@kernel.org> As part of removing the indirect calls and radix tag implementation details from the incore inode walk loop, create an enum to represent the goal of the inode iteration. More immediately, this separate removes the need for the "ICI_NOTAG" define which makes little sense. Signed-off-by: Darrick J. Wong <djwong@kernel.org> --- fs/xfs/xfs_icache.c | 55 ++++++++++++++++++++++++++++++++++++++++----------- fs/xfs/xfs_icache.h | 9 -------- 2 files changed, 43 insertions(+), 21 deletions(-)
Nice. I like the XFS_ICWALK_NULL_TAG addition. Reviewed-by: Dave Chinner <redacted> -- Dave Chinner david@fromorbit.com