bqiang@codeaurora.org writes:

On 2021-09-28 23:12, Kalle Valo wrote:

quoted

Jouni Malinen [off-list ref] writes:

quoted

From: Baochen Qiang <redacted>

Some targets, QCA6390 for example, use only one TCL ring,
it is better to initialize only one ring and leave others
untouched for such targets.

Tested-on: QCA6390 hw2.0 PCI
WLAN.HST.1.0.1-01740-QCAHSTSWPLZ_V2_TO_X86-1

Signed-off-by: Baochen Qiang <redacted>
Signed-off-by: Jouni Malinen <redacted>

It's better? Please be more specific. Does this fix a bug or is this
just a theoretical fix you found during code review?

Yes, this is just a theoretical fix. By "better" I mean there is no
need to initialize
the other two TCL rings for QCA6390 since they are not used.

Thanks, I changed the commit log now to this:

    ath11k: Change number of TCL rings to one for QCA6390
    
    Some targets, QCA6390 for example, use only one TCL ring, it is better to
    initialize only one ring and leave others untouched for such targets.
    
    This is a theoretical fix found during code review, no visible impact.
    
    Tested-on: QCA6390 hw2.0 PCI WLAN.HST.1.0.1-01740-QCAHSTSWPLZ_V2_TO_X86-1

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches