Thread (21 messages) 21 messages, 4 authors, 2021-11-01

Re: [PATCH 2/3] ath11k: change return buffer manager for QCA6390

From: Kalle Valo <hidden>
Date: 2021-10-01 06:27:23
Also in: ath11k

bqiang@codeaurora.org writes:
On 2021-09-28 23:14, Kalle Valo wrote:
quoted
Jouni Malinen [off-list ref] writes:
quoted
From: Baochen Qiang <redacted>

QCA6390 firmware uses HAL_RX_BUF_RBM_SW1_BM, not
HAL_RX_BUF_RBM_SW3_BM.

Tested-on: QCA6390 hw2.0 PCI
WLAN.HST.1.0.1-01740-QCAHSTSWPLZ_V2_TO_X86-1

Signed-off-by: Baochen Qiang <redacted>
Signed-off-by: Jouni Malinen <redacted>
Same question as in patch 1, does this fix a bug or is just a
theoretical issue found during code review?
Yes, this patch did fix a bug.
Ok, please always describe the bug you are fixing in the commit log.
This is documented in the wiki pages which you definitely should read
very carefully, links below.
QCA6390 firmware expects some specific packets from WBM2SW1 ring,
which, however, will not happen because they are routed directly to
host through WBM2SW3 ring due to wrong configuration of RBM.
Can you give higher level description of the bug (from user's
perspective)? For example, what test case was failing or how did you
notice this? I'll then add it to the commit log.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help