Re: [PATCH] brcmfmac: Set SDIO workqueue as WQ_HIGHPRI

On August 17, 2021 6:50:50 PM Sean Anderson [off-list ref] wrote:

ping?

Good idea to ping with a top-level post :-p

On 8/2/21 1:09 PM, Sean Anderson wrote:

quoted

This puts tasks submitted to the SDIO workqueue at the head of the queue
and runs them immediately. This gets higher RX throughput with the SDIO
bus.

This was originally submitted as [1]. The original author Wright Feng
reports

quoted

throughput result with 43455(11ac) on 1 core 1.6 Ghz platform is
Without WQ_HIGGPRI TX/RX: 293/301 (mbps)
With    WQ_HIGHPRI TX/RX: 293/321 (mbps)

I tested this with a 43364(11bgn) on a 1 core 800 MHz platform and got
Without WQ_HIGHPRI TX/RX: 16/19 (Mbits/sec)
With    WQ_HIGHPRI TX/RX: 24/20 (MBits/sec)

[1] 
https://lore.kernel.org/linux-wireless/1584604406-15452-4-git-send-email-wright.feng@cypress.com/ (local)

While I understand the obvious gain it seems like a wrong move to me. What 
if all workqueues in the kernel would start using this flag? I bet the gain 
above would be negated and all are equal in the eyes of .. the kernel

Regards,
Arend