On 2021-08-27 16:20, Johannes Berg wrote:

On Fri, 2021-08-27 at 16:18 +0800, Wen Gong wrote:

quoted

then should I use "struct ieee802_11_elems elems = {0}" or "struct
ieee802_11_elems *elems = kzalloc(sizeof(*elems))"
in the parsing patch?

Yeah, it's a good question ...

We keep adding stuff here, so it'll be safer to alloc it.

I get a fair number of stack size warnings on the build now (possibly
due to the addition of the TPE fields?), and while they're probably 
fine
for now (we get there from nl80211, so no deep stack), it's only going
to increase - we have EHT patches already now, for example.

the TPE is only 8 pointer in the struct ieee802_11_elems.
so stack size warnings should not caused by TPE.

#define IEEE80211_TPE_MAX_IE_COUNT	8
const struct ieee80211_tx_pwr_env 
*tx_pwr_env[IEEE80211_TPE_MAX_IE_COUNT];

johannes