On Thu, 2021-08-26 at 19:00 +0800, Wen Gong wrote:

On 2021-08-26 18:57, Johannes Berg wrote:

quoted

On Thu, 2021-08-26 at 18:50 +0800, Wen Gong wrote:

quoted

quoted

it is memset here i this patch:

Oops, missed that.

But is that really a good place for it? Doesn't really seem to belong 
to
assigning a channel context - maybe put it into set_disassoc()?

it is correct.
you can see it is place together with "drv_unassign_vif_chanctx(local, 
sdata, curr_ctx)"
in ieee80211_assign_vif_chanctx(), it is for disconnect.

Yes, I know it's *correct*, but that doesn't mean it's *good*?

Look at that code - it does nothing with bss_conf. Nobody is ever going
to look there.

johannes