On Thu, 2021-08-26 at 19:02 +0800, Wen Gong wrote:

On 2021-08-26 16:22, Johannes Berg wrote:

quoted

On Thu, 2021-08-26 at 10:20 +0200, Johannes Berg wrote:

quoted

quoted

 struct cfg80211_chan_def {
 	struct ieee80211_channel *chan;

@@ -684,6 +685,7 @@ struct cfg80211_chan_def {

 	u32 center_freq2;
 	struct ieee80211_edmg edmg;
 	u16 freq1_offset;
+	enum nl80211_ap_reg_power power_type;

I'm not sure why this should be in the chandef, there's no way that
anything in cfg80211 is ever using it there, at least in your patches.

Does it even *apply* to a channel? What if I'm connecting to two APs on
the same channel (two client interfaces)?

this is one copy for each connection, each client has its own 
cfg80211_chan_def.

That depends on where you check it - but you're basically saying "use
this only from vif->bss_conf.chandef (or something, didn't check now),
but chandef shows up in many other places and you don't maintain it
anywhere else.

johannes