Thread (38 messages) 38 messages, 4 authors, 2018-09-13

Re: [PATCH RFC v3 0/4] Move TXQ scheduling into mac80211

From: Toke Høiland-Jørgensen <toke@toke.dk>
Date: 2018-09-10 16:09:54

Johannes Berg [off-list ref] writes:
On Sat, 2018-09-08 at 00:22 +0200, Toke H=C3=B8iland-J=C3=B8rgensen wrote:
quoted
- I didn't get rid of the register_airtime() callback. As far as I can t=
ell,
quoted
  only iwlwifi uses the tx_time field in the struct tx_info. Which means=
 that
quoted
  we *could* probably use it for this and just make the other drivers se=
t it;
quoted
  but I'm not sure what effects that would have in relation to WMM-AC for
  those drivers, so I chickened out. Will have to try it out, I guess; b=
ut it
quoted
  also depends on whether ath10k needs to be able to report airtime
  asynchronously anyway. So I'll hold off on that for a bit more.
I don't think you need to be concerned, the reporting through this has
no immediate effect as the driver would also have to set the feature
flag (NL80211_FEATURE_SUPPORTS_WMM_ADMISSION) for userspace to be able
to use WMM admission TSPECs, and getting tx_tspec->admitted_time to be
non-zero in ieee80211_sta_tx_wmm_ac_notify().
Great! In that case I'll try moving the reporting go through the tx_info
struct and check that it works for ath9k :)

-Toke
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help