Thread (38 messages) 38 messages, 4 authors, 2018-09-13

Re: [PATCH RFC v3 0/4] Move TXQ scheduling into mac80211

From: Johannes Berg <johannes@sipsolutions.net>
Date: 2018-09-10 12:44:59

On Sat, 2018-09-08 at 00:22 +0200, Toke Høiland-Jørgensen wrote:
A few things that were discussed in the last round that I did *not* change:
Thanks for this list btw.
- I did not add any locking around next_txq(); the driver is still supposed
  to maintain a lock that prevents two threads from trying to schedule the
  same AC at the same time. This is what drivers already do, so I figured it
  was easier to just keep it that way rather than do it in mac80211.
I'll look at this in the code, but from a maintainer perspective I'm
somewhat worried that this will lead to issues that are really the
driver's fault, but surface in mac80211. I don't know how easy it would
be to catch that.

Might be fine, but something to keep in mind.

johannes
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help