Re: [PATCH RFC v3 1/4] mac80211: Add TXQ scheduling API
From: Johannes Berg <johannes@sipsolutions.net>
Date: 2018-09-10 18:05:02
From: Johannes Berg <johannes@sipsolutions.net>
Date: 2018-09-10 18:05:02
On Mon, 2018-09-10 at 15:08 +0200, Toke Høiland-Jørgensen wrote:
Johannes Berg [off-list ref] writes:quoted
On Mon, 2018-09-10 at 14:39 +0200, Toke Høiland-Jørgensen wrote:quoted
quoted
From then on, right now we basically just try to refill the hardware queue from the TXQ whenever the hardware releases frames from that queue. If there are none, we fall back to putting them on the hardware queue from the wake signal.OK. So if the TXQ is ineligible to dequeue packets, but still have them queued, there would need to be a signal (such as wake_txq()) when it becomes eligible again, right?Right. It wouldn't have to be wake_txq, but that seems as appropriate as anything else. If we were to use ieee80211_airtime_may_transmit(), we'd have to have something that tells us "I previously told you it may not transmit, but now I changed my mind" :-)Yes, exactly. Hmm, I'll see what I can come up with :)
No need to look at this right now - let's get this stuff sorted out first :) johannes