Thread (61 messages) 61 messages, 5 authors, 2018-08-28

Re: [PATCH 23/24] staging: wilc1000: move 'wilc_connecting' static variable to 'wilc_vif' struct

From: Ajay Singh <ajay.kathat@microchip.com>
Date: 2018-08-23 14:57:11

Hi Greg,

On Thu, 23 Aug 2018 12:55:27 +0200
Greg KH [off-list ref] wrote:
On Tue, Aug 14, 2018 at 12:20:15PM +0530, Ajay Singh wrote:
quoted
--- a/drivers/staging/wilc1000/wilc_wfi_netdevice.h
+++ b/drivers/staging/wilc1000/wilc_wfi_netdevice.h
@@ -151,6 +151,7 @@ struct wilc_vif {
 	struct timer_list periodic_rssi;
 	struct rf_info periodic_stat;
 	struct tcp_ack_filter ack_filter;
+	int connecting;  
Shouldn't this be a boolean?
Yes, 'connecting' only have value as 0 or 1. I will change it to
bool and rename it to 'is_connecting'.


Regards,
Ajay
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help