Thread (61 messages) 61 messages, 5 authors, 2018-08-28

Re: [PATCH 10/24] staging: wilc1000: move wilc_multicast_mac_addr_list to 'wilc_vif' struct

From: Ajay Singh <ajay.kathat@microchip.com>
Date: 2018-08-27 09:25:14

Hi Adham,

On Fri, 24 Aug 2018 17:32:46 -0700
Adham Abozaeid [off-list ref] wrote:
On Fri, 24 Aug 2018 11:47:14 +0300
Claudiu Beznea [off-list ref] wrote:
quoted

On 23.08.2018 13:00, Ajay Singh wrote:  
quoted
Unless ndo_set_rx_mode() gets called quickly I don't think there
is any issue here.   
I don't agree with this.  
It would be safer that the mcast list be passed to
wilc_setup_multicast_filter() to be copied to the msg structure then
handled by the worker thread. In this case vif->mc_mac_addr_list can
be removed all together.

Thanks for your suggestion.

Yes, I agree we can allocate and pass 'mac_addr_list' to worker thread
so it can be handled safely. And this solution would be better than
changing handle_set_mcast_filter() to a sync call, which i have
suggested earlier.


Regards,
Ajay
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help