Hi Dan,

On Thu, 23 Aug 2018 15:37:40 +0300
Dan Carpenter [off-list ref] wrote:

On Thu, Aug 23, 2018 at 04:57:48PM +0530, Ajay Singh wrote:

quoted

Hi Greg,

On Thu, 23 Aug 2018 12:55:27 +0200
Greg KH [off-list ref] wrote:
  

quoted

On Tue, Aug 14, 2018 at 12:20:15PM +0530, Ajay Singh wrote:  

quoted

--- a/drivers/staging/wilc1000/wilc_wfi_netdevice.h
+++ b/drivers/staging/wilc1000/wilc_wfi_netdevice.h

@@ -151,6 +151,7 @@ struct wilc_vif {
 	struct timer_list periodic_rssi;
 	struct rf_info periodic_stat;
 	struct tcp_ack_filter ack_filter;
+	int connecting;    

Shouldn't this be a boolean?
  

Yes, 'connecting' only have value as 0 or 1. I will change it to
bool and rename it to 'is_connecting'.  

I think just the name "connecting" implies bool so there is no need
for the "is_".

Ok. So, I will keep the same name and only change its type to
boolean.

Regards,
Ajay