Re: [PATCH 01/10] rsi: add support for hardware scan offload
From: Kalle Valo <hidden>
Date: 2018-03-13 15:16:04
Amitkumar Karwar [off-list ref] writes:
From: Prameela Rani Garnepudi <redacted> With the current approach of scanning, roaming delays are observed. Firmware has support for back ground scanning. To get this advantage, mac80211 hardware scan is implemented. In this method, foreground scan is performed in driver and back ground scan is configured to firmware.
To me doesn't like a good idea to duplicate scan functionality in the driver.
quoted hunk ↗ jump to hunk
--- a/drivers/net/wireless/rsi/rsi_91x_main.c +++ b/drivers/net/wireless/rsi/rsi_91x_main.c@@ -324,6 +324,14 @@ struct rsi_hw *rsi_91x_init(u16 oper_mode) mutex_init(&common->rx_lock); mutex_init(&common->tx_bus_mutex); + rsi_init_event(&common->chan_set_event); + rsi_init_event(&common->probe_cfm_event); + rsi_init_event(&common->chan_change_event); + rsi_init_event(&common->cancel_hw_scan_event);
And I'm starting to dislike this rsi_init_event() even more (see my other mail). In upstream driver's custom abstractions are very much frowned upon, especially that it makes review harder. -- Kalle Valo