Re: [PATCH 01/10] rsi: add support for hardware scan offload

Johannes Berg [off-list ref] writes:

On Fri, 2018-03-23 at 20:20 +0530, Amitkumar Karwar wrote:

quoted

quoted

But maybe that's not really true at all? At least in one case it seems
you just kick off something called "bgscan".

Yes. We have different scan implementations for device is connected
and non-connected cases. In connected case, firmware will take care of
timings when driver configures bgscan parameters due to power save and
coex restrictions. In non-connected state, driver is taking care of
it.
I found hardware scan in mac80211 more suitable for our device.

Yeah it's a bit odd though that you're still implementing software scan
:-)

Perhaps we could make a special return code from the hwscan callback
that would tell mac80211 to fall back to software scanning, so you'd
only implement the connected case, and leave the rest up to mac80211?

Hehe, this is exactly what I proposed during my review :)

-- 
Kalle Valo