Re: [PATCH 01/10] rsi: add support for hardware scan offload

Amitkumar Karwar [off-list ref] writes:

On Tue, Mar 13, 2018 at 8:46 PM, Kalle Valo [off-list ref] wrote:

quoted

Amitkumar Karwar [off-list ref] writes:

quoted

From: Prameela Rani Garnepudi <redacted>

With the current approach of scanning, roaming delays
are observed. Firmware has support for back ground scanning.
To get this advantage, mac80211 hardware scan is implemented.
In this method, foreground scan is performed in driver and
back ground scan is configured to firmware.

To me doesn't like a good idea to duplicate scan functionality in the
driver.

There is a limitation with our device. We need to configure background
scan parameters to firmware when device is connected. 

Yeah, I guessed that.

In non-connected state, we can directly dump probe requests received
from mac80211 as a part of software scan. Some synchronization issues
are with existing software scan when device is connected. This patch
implements hw_scan where these issues are no seen, as driver has more
control on scan state machine

What I don't like here is that you are duplicating functionality already
existing in mac80211 and I hope there is a better way to solve the
problem. Just as a a crazy idea what if the driver returns -EOPNOTSUPP
when hardware scan is not possible and mac80211 falls back to software
scan? But of course this depends on what Johannes thinks.

-- 
Kalle Valo