Thread (20 messages) flat view 20 messages, 4 authors, 2016-09-26

Re: [PATCH v2 RESEND] qtnfmac: announcement of new FullMAC driver for Quantenna chipsets

From: Johannes Berg <johannes@sipsolutions.net>
Date: 2016-09-17 14:50:59

drivers/net/wireless/quantenna/qtnfmac/event.c: In function
`qtnf_event_handle_scan_complete':
drivers/net/wireless/quantenna/qtnfmac/event.c:342:2: warning:
passing argument 2 of `cfg80211_scan_done' makes pointer from integer
without a cast [enabled by default]
Yes, cfg80211_scan_done() changed fairly recently for sure.
./include/net/cfg80211.h:4104:6: note: expected `struct
cfg80211_scan_info *' but argument is of type `u32'
drivers/net/wireless/quantenna/qtnfmac/cfg80211.c: In function
`qtnf_virtual_intf_cleanup':
drivers/net/wireless/quantenna/qtnfmac/cfg80211.c:1093:4: warning:
passing argument 2 of `cfg80211_scan_done' makes pointer from integer
without a cast [enabled by default]
./include/net/cfg80211.h:4104:6: note: expected `struct
cfg80211_scan_info *' but argument is of type `int'
These also seem related.
quoted
+F:   drivers/net/wireless/quantenna/qtnfmac
The include directory is not listed.
Should really just stop after quantenna/ I'd think? As long as it's
just a single driver, you might as well claim maintenance over
everything there :)
I guess some of these static variables could be also const, but
didn't check.
I think both bitrates and channels can't be, due to cfg80211 writing
some (global) flags there on init.

johannes
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help