Re: [PATCH v2 RESEND] qtnfmac: announcement of new FullMAC driver for Quantenna chipsets
From: Kalle Valo <hidden>
Date: 2016-09-26 18:16:47
IgorMitsyanko [off-list ref] writes:
On 09/26/2016 01:56 PM, Kalle Valo wrote:quoted
IgorMitsyanko [off-list ref] writes:quoted
On 09/17/2016 04:46 PM, Kalle Valo wrote:For the initial submission please freeze the driver, otherwise it's pain to review as the driver changes too much in-between review rounds. So at this stage only minimal changes, please. You can continue adding new features and making changes, but do those as follow up patches and use the initial submission as the baseline for the new patches. Once the driver is applied you can submit the rest of the patches adding new features and they will be reviewed similarly like all other wireless patches.Ok, we will keep patch modification to minimum between revisions, but channels-related changes are something we would like to apply: we're setting SELF_MANAGED bit right now and do not handle regulatory hints from cfg80211, having all the regulatory-related info fixed on device itself (region, per-channel Tx powers, DFS requirements). This info is what was used to pass regulatory authorities certification, and considering seriousness of regulatory compliance requirement it's probably better to use the info that is known to be accepted. Would it be acceptable if we keep rates/capabilities logic intact, but will modify channel-related logic in next patch revision?
Sure, regulatory compliance is important and it's understandable that you want to fix that. Just give a short summary in the change log what you changed regarding regulatory to make it easier for the reviewers. -- Kalle Valo