Re: [PATCH 08/20] ath6kl: Request P2P capabilities during target init
From: Raja Mani <hidden>
Date: 2011-08-30 09:54:23
On Monday 29 August 2011 05:53 PM, Jouni Malinen wrote:
quoted hunk ↗ jump to hunk
Signed-off-by: Jouni Malinen<redacted> --- drivers/net/wireless/ath/ath6kl/init.c | 9 +++++++++ 1 files changed, 9 insertions(+), 0 deletions(-)diff --git a/drivers/net/wireless/ath/ath6kl/init.c b/drivers/net/wireless/ath/ath6kl/init.c index ad9716c..aa7440d 100644 --- a/drivers/net/wireless/ath/ath6kl/init.c +++ b/drivers/net/wireless/ath/ath6kl/init.c@@ -417,6 +417,7 @@ void ath6kl_target_failure(struct ath6kl *ar) static int ath6kl_target_config_wlan_params(struct ath6kl *ar) { int status = 0; + int ret; /* * Configure the device for rx dot11 header rules. "0,0" are the@@ -461,6 +462,14 @@ static int ath6kl_target_config_wlan_params(struct ath6kl *ar) status = -EIO; } + ret = ath6kl_wmi_info_req_cmd(ar->wmi, P2P_FLAG_CAPABILITIES_REQ | + P2P_FLAG_MACADDR_REQ | + P2P_FLAG_HMODEL_REQ); + if (ret) { + printk(KERN_DEBUG "ath6l: Failed to request P2P capabilities " + "(%d) - assuming P2P not supported\n", ret);
Is it possible to use ath6kl_dbg() instead of printk here ? Should it be ath6kl_err() ? Another question is , Don't you have to assign error code (may be -EIO) to 'status' variable in case of error ? not sure whether error code assignment needed here or not..
+ } + return status; }