Re: [PATCH 01/20] ath6kl: Add functionality for starting AP mode

On Tuesday 30 August 2011 02:10 PM, Jouni Malinen wrote:

On Tue, Aug 30, 2011 at 11:17:43AM +0530, Raja Mani wrote:

quoted

On Monday 29 August 2011 05:53 PM, Jouni Malinen wrote:

quoted

+static int ath6kl_ap_beacon(struct wiphy *wiphy, struct net_device *dev,
+			    struct beacon_parameters *info, bool add)
+{

quoted

quoted

+	if (!test_bit(WMI_READY,&ar->flag))
+		return -EIO;
+
+	if (!test_bit(WLAN_ENABLED,&ar->flag))
+		return -EIO;

How about calling ath6kl_cfg80211_ready() function to check
WMI_READY and WLAN_ENABLED status ?

Sure, I can do that, but unless something else comes up, I would rather
do it after the patch series goes in. It looks like I missed addition of
that helper function since I started working on this before the cleanup
was complete.

Okay.

By the way.. How did that message lost the space after the commas on
those test_bit lines? They are included in the patch I sent.

When i opened your patch, I saw your complete patch code. Could be 
deleted by mistake when i sent reply..