Re: [PATCH 04/20] ath6kl: Use change_station() to authorize/unauthorize STAs

On Tue, Aug 30, 2011 at 12:06:15PM +0300, Kalle Valo wrote:

On 08/29/2011 03:23 PM, Jouni Malinen wrote:

quoted

--- a/drivers/net/wireless/ath/ath6kl/wmi.h
+++ b/drivers/net/wireless/ath/ath6kl/wmi.h

@@ -1804,6 +1804,21 @@ struct wmi_tx_complete_event {
+/*
+ * Used with WMI_AP_SET_MLME_CMDID
+ */
+struct wmi_ap_set_mlme_cmd {
+	u8 mac[ETH_ALEN];
+	u16 reason;		/* 802.11 reason code */
+	u8 cmd;			/* operation to perform */
+/* MLME Commands */
+#define WMI_AP_MLME_ASSOC       1   /* associate station */
+#define WMI_AP_DISASSOC         2   /* disassociate station */
+#define WMI_AP_DEAUTH           3   /* deauthenticate station */
+#define WMI_AP_MLME_AUTHORIZE   4   /* authorize station */
+#define WMI_AP_MLME_UNAUTHORIZE 5   /* unauthorize station */
+} __packed;

Needs an endian annotation for u16. Also defines inside a struct are
IMHO a bit awkward.

Thanks, fixed.

-- 
Jouni Malinen                                            PGP id EFC895FA