Re: [PATCH v4 7/7] kernel.h: drop trace_printk.h
From: Steven Rostedt <rostedt@goodmis.org>
Date: 2026-01-05 16:38:49
Also in:
dri-devel, intel-gfx, linux-modules, lkml
From: Steven Rostedt <rostedt@goodmis.org>
Date: 2026-01-05 16:38:49
Also in:
dri-devel, intel-gfx, linux-modules, lkml
On Sun, 4 Jan 2026 02:20:55 +0200 Andy Shevchenko [off-list ref] wrote:
quoted
I do not think it is necessary to move it.I'm not talking about move, I'm talking about the C 101 thingy. Any custom API should be included before use, otherwise compiler won't see it. Which header do you want to include to have this API being provided? Note, it's really bad situation right now with the header to be included implicitly via non-obvious or obscure path. The discussion moved as far as I see it towards the finding a good place for the trace_printk.h.
It's not a normal API. It's for debugging the kernel. Thus it should be available everywhere without having to add a header. Hence, the best place to include trace_printk.h, is in kernel.h. I'm thinking that my proposed config option is the best solution now. For those that do not care about debugging the kernel, you enable the "HIDE_TRACE_PRINTK" config so that your builds will be "quicker". But for everyone else, it will not slow down their workflow when they need to debug code. -- Steve