Re: [PATCH v4 7/7] kernel.h: drop trace_printk.h
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Date: 2025-12-30 08:55:16
Also in:
dri-devel, intel-gfx, linux-modules, lkml
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Date: 2025-12-30 08:55:16
Also in:
dri-devel, intel-gfx, linux-modules, lkml
On Mon, Dec 29, 2025 at 05:25:08PM -0500, Mathieu Desnoyers wrote: ...
One possible compromise would be to move it to its own header file, and introduce a CONFIG_TRACE_PRINTK Kconfig option (default Y) that would surround an include from linux/kernel.h with a preprocessor conditional. But please make sure the default stays as it is today: include the trace printk header by default.
"by default" where exactly? The problem is that kernel.h is a total mess and it's included in a lot of mysterious ways (indirectly), and in C you _must_ include a header anyway for a custom API, just define *which* one. Based on the Steven's first replies I see a compromise in having it inside printk.h. If you want to debug something with printf() (in general) the same header should provide all species. Do you agree? -- With Best Regards, Andy Shevchenko