On Sun, 22 Aug 2021 at 18:04, Martin Kaiser [off-list ref] wrote:

Thus wrote Phillip Potter (phil@philpotter.co.uk):

quoted

On Sat, 21 Aug 2021 at 17:49, Martin Kaiser [off-list ref] wrote:

quoted

quoted

name is a const char * by default. This type should be ok for r8188eu.

quoted

quoted

Signed-off-by: Martin Kaiser <redacted>
---
 drivers/staging/r8188eu/os_dep/usb_intf.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

quoted

quoted

diff --git a/drivers/staging/r8188eu/os_dep/usb_intf.c b/drivers/staging/r8188eu/os_dep/usb_intf.c
index e002070f7fba..72556ac10d7d 100644
--- a/drivers/staging/r8188eu/os_dep/usb_intf.c
+++ b/drivers/staging/r8188eu/os_dep/usb_intf.c

@@ -61,7 +61,7 @@ struct rtw_usb_drv {
 };

quoted

quoted

 static struct rtw_usb_drv rtl8188e_usb_drv = {
-       .usbdrv.name = (char *)"r8188eu",
+       .usbdrv.name = "r8188eu",
        .usbdrv.probe = rtw_drv_init,
        .usbdrv.disconnect = rtw_dev_remove,
        .usbdrv.id_table = rtw_usb_id_tbl,
--
2.20.1

Hi Phil,

quoted

Looks ok to me, thanks. I would consider using a cover letter style
[PATCH 00/10] style approach as an addition in future though, just my
personal opinion.

quoted

Acked-by: Phillip Potter <phil@philpotter.co.uk>

Thanks.

This series is a mixed bag of things I found while poking around in the
code. So I didn't think there was anything useful to say in a cover
letter. Still, I see your point, it makes sense for a patch series to
have a cover letter, I'll add one for future patch series.

Best regards,
Martin

Reasonable point for sure - it is your call ultimately, I like your
work in any case, so many thanks :-)

Regards,
Phil