Re: [PATCH 01/10] staging: r8188eu: remove unnecessary cast
From: Phillip Potter <phil@philpotter.co.uk>
Date: 2021-08-21 17:27:16
Also in:
lkml
On Sat, 21 Aug 2021 at 17:49, Martin Kaiser [off-list ref] wrote:
quoted hunk ↗ jump to hunk
name is a const char * by default. This type should be ok for r8188eu. Signed-off-by: Martin Kaiser <redacted> --- drivers/staging/r8188eu/os_dep/usb_intf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/drivers/staging/r8188eu/os_dep/usb_intf.c b/drivers/staging/r8188eu/os_dep/usb_intf.c index e002070f7fba..72556ac10d7d 100644 --- a/drivers/staging/r8188eu/os_dep/usb_intf.c +++ b/drivers/staging/r8188eu/os_dep/usb_intf.c@@ -61,7 +61,7 @@ struct rtw_usb_drv { }; static struct rtw_usb_drv rtl8188e_usb_drv = { - .usbdrv.name = (char *)"r8188eu", + .usbdrv.name = "r8188eu", .usbdrv.probe = rtw_drv_init, .usbdrv.disconnect = rtw_dev_remove, .usbdrv.id_table = rtw_usb_id_tbl, --2.20.1
Looks ok to me, thanks. I would consider using a cover letter style [PATCH 00/10] style approach as an addition in future though, just my personal opinion. Acked-by: Phillip Potter <phil@philpotter.co.uk> Regards, Phil