Thread (34 messages) 34 messages, 4 authors, 2021-08-22

Re: [PATCH 05/10] staging: r8188eu: remove an unused enum

From: Michael Straube <hidden>
Date: 2021-08-22 12:20:03
Also in: lkml

On 8/21/21 6:48 PM, Martin Kaiser wrote:
quoted hunk ↗ jump to hunk
The VENDOR_READ and VENDOR_WRITE defines are not used.

Signed-off-by: Martin Kaiser <redacted>
---
  drivers/staging/r8188eu/include/usb_ops.h | 4 ----
  1 file changed, 4 deletions(-)
diff --git a/drivers/staging/r8188eu/include/usb_ops.h b/drivers/staging/r8188eu/include/usb_ops.h
index b6a1cd536adf..c53cc54b6b87 100644
--- a/drivers/staging/r8188eu/include/usb_ops.h
+++ b/drivers/staging/r8188eu/include/usb_ops.h
@@ -13,10 +13,6 @@
  #define REALTEK_USB_VENQT_CMD_REQ	0x05
  #define REALTEK_USB_VENQT_CMD_IDX	0x00
  
-enum {
-	VENDOR_WRITE = 0x00,
-	VENDOR_READ = 0x01,
-};
  #define ALIGNMENT_UNIT			16
  #define MAX_VENDOR_REQ_CMD_SIZE	254	/* 8188cu SIE Support */
  #define MAX_USB_IO_CTL_SIZE	(MAX_VENDOR_REQ_CMD_SIZE + ALIGNMENT_UNIT)
Looks good to me.

Acked-by: Michael Straube <redacted>

Thanks,
Michael
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help