Thread (22 messages) 22 messages, 5 authors, 2012-08-01

Re: [PATCH 09/12] commit 22126843cb3c2a782c2d52614486115f3e9db478

From: Yinghai Lu <yinghai@kernel.org>
Date: 2012-08-01 00:51:44
Also in: lkml
Subsystem: the rest, usb serial subsystem, usb subsystem · Maintainers: Linus Torvalds, Johan Hovold, Greg Kroah-Hartman

On Fri, Jun 22, 2012 at 10:04 AM, Alan Cox [off-list ref] wrote:
On Fri, 22 Jun 2012 08:36:57 -0700
Greg KH [off-list ref] wrote:
quoted
On Fri, Jun 22, 2012 at 04:44:59PM +0100, Alan Cox wrote:
quoted
From: Alan Cox <redacted>

tty: move the termios object into the tty

    This will let us sort out a whole pile of tty related races. The
    alternative would be to keep points and refcount the termios objects.
    However
    1. They are tiny anyway
    2. Many devices don't use the stored copies
    3. We can remove a pty special case

    Signed-off-by: Alan Cox [off-list ref]
Odd subject line, and formatting, did something go wrong with your
scripts?
Apparently so. I will given them a stern talking to and repost
looks the one in tty-next still missed some changes...

commit adc8d746caa67fff4b53ba3e5163a6cbacc3b523
Author: Alan Cox [off-list ref]
Date:   Sat Jul 14 15:31:47 2012 +0100

    tty: move the termios object into the tty

    This will let us sort out a whole pile of tty related races. The
    alternative would be to keep points and refcount the termios objects.
    However
    1. They are tiny anyway
    2. Many devices don't use the stored copies
    3. We can remove a pty special case

    Signed-off-by: Alan Cox [off-list ref]
    Signed-off-by: Greg Kroah-Hartman [off-list ref]

...

still need
diff --git a/drivers/usb/serial/console.c b/drivers/usb/serial/console.c
index b9cca6d..9a56428 100644
--- a/drivers/usb/serial/console.c
+++ b/drivers/usb/serial/console.c
@@ -165,8 +165,8 @@ static int usb_console_setup(struct console *co,
char *options)
                }

                if (serial->type->set_termios) {
-                       tty->termios->c_cflag = cflag;
-                       tty_termios_encode_baud_rate(tty->termios, baud, baud);
+                       tty->termios.c_cflag = cflag;
+                       tty_termios_encode_baud_rate(&tty->termios, baud, baud);
                        memset(&dummy, 0, sizeof(struct ktermios));
                        serial->type->set_termios(tty, port, &dummy);
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help