Re: [PATCH 02/12] usb: fix sillies in the metro USB driver
From: Jiri Slaby <hidden>
Date: 2012-06-24 21:49:32
Also in:
lkml
On 06/22/2012 05:38 PM, Alan Cox wrote:
quoted hunk ↗ jump to hunk
Bits noticed doing the termios conversion Signed-off-by: Alan Cox <redacted> --- drivers/usb/serial/metro-usb.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-)diff --git a/drivers/usb/serial/metro-usb.c b/drivers/usb/serial/metro-usb.c index 81423f7..bad5f0c 100644 --- a/drivers/usb/serial/metro-usb.c +++ b/drivers/usb/serial/metro-usb.c@@ -130,20 +130,14 @@ static void metrousb_read_int_callback(struct urb *urb)
...
if (tty && urb->actual_length) {
/* Loop through the data copying each byte to the tty layer. */
tty_insert_flip_string(tty, data, urb->actual_length);
/* Force the data to the tty layer. */
tty_flip_buffer_push(tty);
+ tty_kref_put(tty);
}
- tty_kref_put(tty);This doesn't seem right. (Depends on whether tty is non-null iff urb->actual_length is non-zero.) thanks, -- js suse labs