Thread (22 messages) 22 messages, 5 authors, 2012-08-01

Re: [PATCH 06/12] 8250: use the 8250 register interface not the legacy one

From: Greg KH <hidden>
Date: 2012-06-27 02:30:27
Also in: lkml

On Fri, Jun 22, 2012 at 04:43:51PM +0100, Alan Cox wrote:
quoted hunk ↗ jump to hunk
@@ -69,7 +69,6 @@ struct uart_port;
 struct uart_8250_port;
 
 int serial8250_register_8250_port(struct uart_8250_port *);
-int serial8250_register_port(struct uart_port *);
There are still in-kernel callers of this function, so I don't think
it's safe to remove just yet, otherwise the build will break:

drivers/char/mwave/mwavedd.c:   return serial8250_register_port(&uart);
drivers/misc/ibmasm/uart.c:     sp->serial_line = serial8250_register_port(&uport);
drivers/net/ethernet/sgi/ioc3-eth.c:    serial8250_register_port(&port);
drivers/tty/serial/of_serial.c:         ret = serial8250_register_port(&port);

I'm stopping here on this series, I've only applied the one that added
the comment, that seems to be the only one that compiled properly :(

Care to redo these please?

thanks,

greg k-h
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help