Re: [PATCH V2] rtc: mc146818: Dont test for bit 0-5 in Register D
From: Borislav Petkov <bp@alien8.de>
Date: 2021-02-01 20:10:48
Also in:
lkml
Possibly related (same subject, not in this thread)
- 2021-02-01 · Re: [PATCH V2] rtc: mc146818: Dont test for bit 0-5 in Register D · Dirk Gouders <hidden>
On Mon, Feb 01, 2021 at 08:24:17PM +0100, Thomas Gleixner wrote:
The recent change to validate the RTC turned out to be overly tight.
While it cures the problem on the reporters machine it breaks machines
with Intel chipsets which use bit 0-5 of the D register. So check only
for bit 6 being 0 which is the case on these Intel machines as well.
Fixes: 211e5db19d15 ("rtc: mc146818: Detect and handle broken RTCs")
Reported-by: Serge Belyshev <redacted>
Reported-by: Dirk Gouders <redacted>
Signed-off-by: Thomas Gleixner <redacted>
---
V2: Provide the actual delta patch. Should have stayed away from
computers today....
---
drivers/rtc/rtc-cmos.c | 4 ++--
drivers/rtc/rtc-mc146818-lib.c | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
FWIW:
Reported-by: Borislav Petkov <redacted>
Tested-by: Borislav Petkov <redacted>
Thx.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette