Re: [PATCH V2] rtc: mc146818: Dont test for bit 0-5 in Register D
From: Alexandre Belloni <alexandre.belloni@bootlin.com>
Date: 2021-02-01 19:39:52
Also in:
lkml
On 01/02/2021 20:24:17+0100, Thomas Gleixner wrote:
The recent change to validate the RTC turned out to be overly tight.
While it cures the problem on the reporters machine it breaks machines
with Intel chipsets which use bit 0-5 of the D register. So check only
for bit 6 being 0 which is the case on these Intel machines as well.
Fixes: 211e5db19d15 ("rtc: mc146818: Detect and handle broken RTCs")
Reported-by: Serge Belyshev <redacted>
Reported-by: Dirk Gouders <redacted>
Signed-off-by: Thomas Gleixner <redacted>Acked-by: Alexandre Belloni <alexandre.belloni@bootlin.com> I'm still fine with that going through your tree. Thanks for this work I do hope this will be the last issue... -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com