Re: [PATCH V5 08/20] rtla: Helper functions for rtla
From: Daniel Bristot de Oliveira <bristot@kernel.org>
Date: 2021-10-26 19:45:55
Also in:
lkml
On 10/26/21 18:26, Steven Rostedt wrote:
On Wed, 27 Oct 2021 00:22:04 +0800 Tao Zhou [off-list ref] wrote:quoted
quoted
+ do { + retval = read(in_fd, buffer, sizeof(buffer)); + if (read <= 0)check "retval" not read. Like: if (retval <= 0)OUCH! Good check. Daniel, did that not produce any warnings??
OUCH OUCH! No warnings, no nothing. The code actually "works" because errors are not common and the next if stops the loop. -- Daniel
-- Steve