Re: [PATCH V5 08/20] rtla: Helper functions for rtla

From
Daniel Bristot de Oliveira <bristot@kernel.org>
Date
2021-10-26 19:45:55
Also in
lkml
Reply to
Steven Rostedt, 2021-10-26
On 10/26/21 18:26, Steven Rostedt wrote:
On Wed, 27 Oct 2021 00:22:04 +0800
Tao Zhou [off-list ref] wrote:
quoted
quoted
+	do {
+		retval = read(in_fd, buffer, sizeof(buffer));
+		if (read <= 0)  
check "retval" not read. Like:

  if (retval <= 0)
OUCH! Good check.

Daniel, did that not produce any warnings??
OUCH OUCH!

No warnings, no nothing.

The code actually "works" because errors are not common and the next if stops
the loop.

-- Daniel
-- Steve
  
Thread (32 messages) 32 messages, 3 authors, last reply 2021-10-26
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help