Re: [PATCH V5 04/20] trace/osnoise: Use start/stop_per_cpu_kthreads() on osnoise_cpus_write()
From: Steven Rostedt <rostedt@goodmis.org>
Date: 2021-10-26 01:08:49
Also in:
lkml
On Mon, 25 Oct 2021 19:40:29 +0200 Daniel Bristot de Oliveira [off-list ref] wrote:
When writing a new CPU mask via osnoise/cpus, if the tracer is running, the workload is restarted to follow the new cpumask. The restart is currently done using osnoise_workload_start/stop(), which disables the workload *and* the instrumentation. However, disabling the instrumentation is not necessary. Calling start/stop_per_cpu_kthreads() is enough to apply the new osnoise/cpus config. No functional change.
I nuked the "No functional change.". You can't have the changes of the above and say there wasn't functional changes, as the first paragraph explains the functional changes. -- Steve