Thread (36 messages) 36 messages, 5 authors, 2008-03-03

Re: [(RT RFC) PATCH v2 3/9] rearrange rt_spin_lock sleep

From: Pavel Machek <hidden>
Date: 2008-02-25 21:54:37
Also in: lkml 

Hi!
quoted hunk ↗ jump to hunk
@@ -720,7 +728,8 @@ rt_spin_lock_slowlock(struct rt_mutex *lock)
 	 * saved_state accordingly. If we did not get a real wakeup
 	 * then we return with the saved state.
 	 */
-	saved_state = xchg(&current->state, TASK_UNINTERRUPTIBLE);
+	saved_state = current->state;
+	smp_mb();
 
 	for (;;) {
 		unsigned long saved_flags;
Please document what the barrier is good for.

Plus, you are replacing atomic operation with nonatomic; is that ok?

									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help