Re: [PATCH net-next v2 7/9] net: use core MTU range checking in misc drivers

From
Stefan Richter <stefanr@s5r6.in-berlin.de>
Date
2016-10-22 19:17:04
Also in
lkml, netdev
Reply to
Jarod Wilson, 2016-10-20
On Oct 20 Jarod Wilson wrote:
firewire-net:
- set min/max_mtu
- remove fwnet_change_mtu
[...]
quoted hunk ↗ jump to hunk
--- a/drivers/firewire/net.c
+++ b/drivers/firewire/net.c
[...]
quoted hunk ↗ jump to hunk
@@ -1478,9 +1467,10 @@ static int fwnet_probe(struct fw_unit *unit,
 	 * Use the RFC 2734 default 1500 octets or the maximum payload
 	 * as initial MTU
 	 */
-	max_mtu = (1 << (card->max_receive + 1))
-		  - sizeof(struct rfc2734_header) - IEEE1394_GASP_HDR_SIZE;
-	net->mtu = min(1500U, max_mtu);
+	net->max_mtu = (1 << (card->max_receive + 1))
+		       - sizeof(struct rfc2734_header) - IEEE1394_GASP_HDR_SIZE;
+	net->mtu = min(1500U, net->max_mtu);
+	net->min_mtu = ETH_MIN_MTU;
 
 	/* Set our hardware address while we're at it */
 	ha = (union fwnet_hwaddr *)net->dev_addr;
Please preserve the current behavior, i.e. do not enforce any particular
upper bound.  (Especially none based on the local link layer controller's
max_receive parameter.)

BTW, after having read RFC 2734, RFC 3146, and the code, I am convinced
that net->mtu should be initialized to 1500, not less.  But such a change
should be done in a separate patch.
-- 
Stefan Richter
-======----- =-=- =-==-
http://arcgraph.de/sr/
Thread (5 messages) 5 messages, 5 authors, last reply 2016-10-22
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help