Thread (32 messages) 32 messages, 5 authors, 2023-04-10

Re: [PATCH v2 05/19] md: use __bio_add_page to add single page

From: Song Liu <song@kernel.org>
Date: 2023-03-31 17:47:28
Also in: dm-devel, linux-block, linux-btrfs, linux-fsdevel, linux-mm

On Thu, Mar 30, 2023 at 3:44 AM Johannes Thumshirn
[off-list ref] wrote:
The md-raid superblock writing code uses bio_add_page() to add a page to a
newly created bio. bio_add_page() can fail, but the return value is never
checked.

Use __bio_add_page() as adding a single page to a newly created bio is
guaranteed to succeed.

This brings us a step closer to marking bio_add_page() as __must_check.

Signed-of_-by: Johannes Thumshirn [off-list ref]
Reviewed-by: Damien Le Moal <redacted>
Acked-by: Song Liu <song@kernel.org>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help