Thread (32 messages) 32 messages, 5 authors, 2023-04-10

Re: [PATCH v2 00/19] bio: check return values of bio_add_page

From: David Sterba <hidden>
Date: 2023-03-30 15:52:29
Also in: dm-devel, linux-block, linux-btrfs, linux-fsdevel, linux-mm

On Thu, Mar 30, 2023 at 03:43:42AM -0700, Johannes Thumshirn wrote:
We have two functions for adding a page to a bio, __bio_add_page() which is
used to add a single page to a freshly created bio and bio_add_page() which is
used to add a page to an existing bio.

While __bio_add_page() is expected to succeed, bio_add_page() can fail.

This series converts the callers of bio_add_page() which can easily use
__bio_add_page() to using it and checks the return of bio_add_page() for
callers that don't work on a freshly created bio.

Lastly it marks bio_add_page() as __must_check so we don't have to go again
and audit all callers.

Changes to v1:
- Removed pointless comment pointed out by Willy
- Changed commit messages pointed out by Damien
- Colledted Damien's Reviews and Acks

Johannes Thumshirn (19):
  btrfs: repair: use __bio_add_page for adding single page
  btrfs: raid56: use __bio_add_page to add single page
The btrfs patches added to misc-next, thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help