[PATCH v2 12/19] zonefs: use __bio_add_page for adding single page to bio
From: Johannes Thumshirn <hidden>
Date: 2023-03-30 10:46:51
Also in:
dm-devel, linux-block, linux-btrfs, linux-fsdevel, linux-mm
Subsystem:
filesystems (vfs and infrastructure), the rest, zonefs filesystem · Maintainers:
Alexander Viro, Christian Brauner, Linus Torvalds, Damien Le Moal, Naohiro Aota
The zonefs superblock reading code uses bio_add_page() to add a page to a newly created bio. bio_add_page() can fail, but the return value is never checked. Use __bio_add_page() as adding a single page to a newly created bio is guaranteed to succeed. This brings us a step closer to marking bio_add_page() as __must_check. Signed-off-by: Johannes Thumshirn <redacted> Acked-by: Damien Le Moal <redacted> --- fs/zonefs/super.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/zonefs/super.c b/fs/zonefs/super.c
index 23b8b299c64e..9350221abfc5 100644
--- a/fs/zonefs/super.c
+++ b/fs/zonefs/super.c@@ -1128,7 +1128,7 @@ static int zonefs_read_super(struct super_block *sb) bio_init(&bio, sb->s_bdev, &bio_vec, 1, REQ_OP_READ); bio.bi_iter.bi_sector = 0; - bio_add_page(&bio, page, PAGE_SIZE, 0); + __bio_add_page(&bio, page, PAGE_SIZE, 0); ret = submit_bio_wait(&bio); if (ret)
--
2.39.2