Thread (12 messages) 12 messages, 4 authors, 2022-08-24

Re: [PATCH v3] Grow: Split Grow_reshape into helper function

From: Jes Sorensen <hidden>
Date: 2022-08-24 15:56:59

On 8/8/22 06:03, Coly Li wrote:
quoted
2022年8月8日 04:41,Jes Sorensen [off-list ref] 写道:

On 6/9/22 03:41, Mateusz Kusiak wrote:
quoted
Grow_reshape should be split into helper functions given its size.
- Add helper function for preparing reshape on external metadata.
- Close cfd file descriptor.
Signed-off-by: Mateusz Kusiak <redacted>
---
Changes since v2:
- removed dot from commit message
- formatted commit description as a list
- got rid of returning -1 in prepare_external_reshape()
- changed "return" section in prepare_external_reshape() description
Hi Mateusz,

Changes look good to me, but it no longer applies. Mind sending an updated version?
Hi Jes,

Please check the version I post to you in series “mdadm-CI for-jes/20220728: patches for merge” (Message-Id: [ref]), the patch in this series is rebased and confirmed with Mateusz, it could be applied to upstream mdadm.
Hi

I applied this one, but none of the versions applied cleanly. I had to
play formail games to pull it out of your stack, as I am not going to
apply a set of 23 commits in one batch without going through them.

It's really awesome to have your help reviewing patches, much
appreciated, but I would prefer to keep them in the original batches so
I can pull them from patchwork, rather than trying to deal with the
giant stack.

Best regards,
Jes

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help