Thread (12 messages) 12 messages, 4 authors, 2022-08-24

Re: [PATCH v3] Grow: Split Grow_reshape into helper function

From: Coly Li <hidden>
Date: 2022-06-28 15:56:26

2022年6月21日 01:21,Coly Li [off-list ref] 写道:


quoted
2022年6月9日 15:41,Mateusz Kusiak [off-list ref] 写道:

Grow_reshape should be split into helper functions given its size.
- Add helper function for preparing reshape on external metadata.
- Close cfd file descriptor.

Signed-off-by: Mateusz Kusiak <redacted>
Hi Mateusz,

Overall I am fine with this patch. Currently it dose apply on branch 20220621-testing of the mdadm-CI tree. This branch is based on mdadm upstream commit 756a15f32338 (“imsm: Remove possibility for get_imsm_dev to return NULL”) and stacked with other asked patch from for-jes/20220620.

I will response this patch after other queuing patches are handled by Jes. If the change is minor, I will do the patch rebase and inform you.
Hi Mateusz,

I just rebased the patch and pushed to mdadm-CI tree into branch 20220621-testing. This is the only patch in this testing branch. It looks fine to me, but can you help to confirm whether the rebase is correctly? The conflict happens in Grow.c:Grow_reshap().

Thanks.

Coly Li
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help