Thread (59 messages) 59 messages, 7 authors, 2022-04-30

Re: [PATCH v2 05/12] md/raid5: Factor out helper from raid5_make_request() loop

From: Christoph Hellwig <hch@infradead.org>
Date: 2022-04-21 06:15:56
Also in: lkml

+	if (unlikely(conf->reshape_progress != MaxSector)) {
+		/* spinlock is needed as reshape_progress may be
Normal kernel style is to stat with a

		/*

line and to captalize the first word.  (also applies for a few other
comments).
+		if (must_retry) {
+			raid5_release_stripe(sh);
+			return STRIPE_SCHEDULE_AND_RETRY;
The raid5_release_stripe cleanup is duplicated a few times.  I think
using goto based unwinding would be hepful in this function.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help