Re: [PATCH v2 01/13] nvdimm/btt: do not call del_gendisk() if not needed
From: Luis Chamberlain <mcgrof@kernel.org>
Date: 2021-11-03 16:59:15
Also in:
linux-block, linux-scsi, lkml
On Wed, Nov 03, 2021 at 05:02:43PM +0100, Christoph Hellwig wrote:
On Wed, Nov 03, 2021 at 05:21:45AM -0700, Luis Chamberlain wrote:quoted
del_gendisk() is not required if the disk has not been added. On kernels prior to commit 40b3a52ffc5bc3 ("block: add a sanity check for a live disk in del_gendisk") it is mandatory to not call del_gendisk() if the underlying device has not been through device_add().And even with the sanity check is it wrong, and will trigger a WARN_ON. So maybe this commit log could use a little update? With that fixed I think this should go into 5.16 and -stable. Reviewed-by: Christoph Hellwig <hch@lst.de>
OK true, the first WARN_ON() was added on v5.11 through commit 6b3ba9762f9f9
("block: cleanup del_gendisk a bit") though, before that, it is still
wrong. Will send a v3 for this patch alone.
Luis